[Webkit-unassigned] [Bug 30902] Need a layout test for Bug 28284

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 30 04:44:56 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30902


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42089|0                           |1
        is obsolete|                            |




--- Comment #3 from Hironori Bono <hbono at chromium.org>  2009-10-30 04:44:55 PDT ---
Created an attachment (id=42206)
 --> (https://bugs.webkit.org/attachment.cgi?id=42206)
The second layout test (without eventSender)

Thank you for your review and comments.

> > +    // Insert a Thai character U+0E01.
> > +    eventSender.keyDown(String.fromCharCode(0x0E01));
>
> I believe there is a way to make this test work without using eventSender. See,
> for example, events/option-tab.html and forms/input-text-enter.html which
> create a keyboard event using the DOM.
>
> Please make a version that does not use eventSender, or explain why not.

You are totally right. This test doesn't need eventSender at all. (Sorry, I
used eventSender without deep consideration.)
Bug #28284 happens when we insert a Thai character into a text node in some
way, such as keyboard-typing, copy-and-paste, DOM events, etc.
(I should have used "Node.innerText += String.fromCharCode(0x0E01);'.)

I have updated this change to use "Node.innerText" instead of
'eventSender.keyDown()'.
Would it be possible to review the updated change?

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list