[Webkit-unassigned] [Bug 30832] Notify the chrome when the focused node has changed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30832


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42121|review?                     |review-
               Flag|                            |




--- Comment #10 from David Levin <levin at chromium.org>  2009-10-29 22:20:03 PDT ---
(From update of attachment 42121)
My only concern is that this will break the builds for non-chromium clients.

I think the easiest way to handle this is to not make this function pure  
   "virtual void focusedNodeChanged(Node*) = 0" 
but I would recommend against this.

The very nice thing about pure methods is that they help ports to quick realize
when they got broken by a parameter being added/changed/etc.

So instead it would be *much better* to find each class that derives from
ChromeClient and given them a default implementation that does nothing.

With this last change, I think this will be ready to go in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.