[Webkit-unassigned] [Bug 30876] [GTK] Make timeout callbacks hold the GDK lock

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30876





--- Comment #3 from Xan Lopez <xan.lopez at gmail.com>  2009-10-29 11:50:48 PDT ---
(In reply to comment #2)
> I have a slightly modified concern. In the long run we want to build a separate
> JSC so and this might not require a GUI and linking to GDK might seem
> excessive. From what I see the modified function in JSC will not be executed
> from within JSC though..

That's right, and that sucks. So maybe we'll have to go the "find all the
places that need protection and protect them...".

> Did you check WebCore/platform/gtk/SharedTimerGtk.cpp? is that safe?

No, it's exactly the same. g_timeout_add/g_idle_add don't hold the GDK lock in
their callbacks, so if some other thread kicks in when that is being executed,
and the callback ends up calling GTK+, you'll have two threads using GTK+ at
the same time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.