[Webkit-unassigned] [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25534


Joanmarie Diggs <joanmarie.diggs at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41963|0                           |1
        is obsolete|                            |
  Attachment #41963|review?                     |
               Flag|                            |
  Attachment #42083|                            |review?
               Flag|                            |




--- Comment #33 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-10-28 23:09:41 PDT ---
Created an attachment (id=42083)
 --> (https://bugs.webkit.org/attachment.cgi?id=42083)
Table 2 - Address Jan's comments

(In reply to comment #21)
> (From update of attachment 41963 [details])
> >      AccessibilityTableCell* AXCell = cell(table, row, column);
> 
> One minor nit: this should be axCell.

Ok. Given that it's in existing code and not added by this patch, I left that
particular one alone. Hope that's ok!(?) But I've already promised Xan I'd go
through the Atk a11y stuff with a lint brush. My current list is:

* Trailing whitespace
* NULL
* AXFoo should be axFoo

Bug 30901 has just been created so y'all can add to the list. :-)

> > +static gint webkit_accessible_table_get_column_at_index(AtkTable* table, gint index)
> > +{
> > +    AccessibilityTableCell* AXCell = cellAtIndex(table, index);
> 
> Ditto.

Changed.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.