[Webkit-unassigned] [Bug 30304] struct RGBA32Buffer is twice as big as the old ImageData of Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 16:24:28 PDT 2009


--- Comment #17 from Darin Adler <darin at apple.com>  2009-10-28 16:24:28 PDT ---
(In reply to comment #16)
> If we want to discourage this, it seems like we should go ahead and add it to
> the style guide.

If you’d like to start doing this in WebKit, I think you should talk with other
people about it in webkit-dev. It’s not debatable what the current style is.
Look at existing WebKit code. Just open almost any source file such as
Frame.cpp and you'll see lots of cases where const could be used for a local
variable and is not.

I don’t think it’s the burden of the style guide to list every convention
that’s followed. In general, the burden is on the person who wants to change
style to tell other people about it on the mailing list and get some feedback
before simply doing it in new code with one reviewer looking at it.

On the other hand, I’d welcome a comment mentioning in this in the style guide.
And I also think it might be good to start using const for local variables.
It’s a bit verbose to have all those extra const, but also neat to be able to
distinguish variables that don’t change from those that do.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list