[Webkit-unassigned] [Bug 30721] [GTK] DRT reports error in the wrong test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 15:06:24 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30721


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41855|review?                     |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-10-28 15:06:24 PDT ---
(From update of attachment 41855)
Chromium recently had similar troubles.  I still think putting this in some
nicely named function would make this much clearer.  As-is, if we ever need to
modify the "test shut down" procedure, it's difficult to tell where it is or
what all of the code should be moved were this ever to move again.  r- because
I really think this needs to be put in a function with a nice name and called
from this runTests() location.

sendPixelResultsEOF() or something even more descriptive?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list