[Webkit-unassigned] [Bug 30863] [Qt] Fix linking on Linux 32-bit.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 14:36:23 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30863





--- Comment #2 from Mark Rowe (bdash) <mrowe at apple.com>  2009-10-28 14:36:23 PDT ---
(From update of attachment 42032)
> diff --git a/JavaScriptCore/jit/JITStubs.cpp b/JavaScriptCore/jit/JITStubs.cpp
> index c999618..9fa898a 100644
> --- a/JavaScriptCore/jit/JITStubs.cpp
> +++ b/JavaScriptCore/jit/JITStubs.cpp
> @@ -75,7 +75,7 @@ namespace JSC {
>  #define THUMB_FUNC_PARAM(name)
>  #endif
>  
> -#if PLATFORM(LINUX) && PLATFORM(X86_64)
> +#if PLATFORM(LINUX) && (PLATFORM(X86_64) || PLATFORM(X86))
>  #define SYMBOL_STRING_RELOCATION(name) #name "@plt"
>  #else
>  #define SYMBOL_STRING_RELOCATION(name) SYMBOL_STRING(name)

It’s not clear why it’s necessary given that this code is well-tested on 32-bit
Linux already.  There’s nothing in the ChangeLog to explain it either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list