[Webkit-unassigned] [Bug 25897] [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25897


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42052|review?                     |review-
               Flag|                            |




--- Comment #15 from Xan Lopez <xan.lopez at gmail.com>  2009-10-28 13:43:05 PDT ---
(From update of attachment 42052)
> AccessibilityObjectPlatformInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
> {
>+    AccessibilityObject* parent = parentObject();
>+    if (not parent)

Come again?

>+        return DefaultBehavior;

The only case where this happens is with the WebView itself, right?

>+
>     // When a list item is made up entirely of children (e.g. paragraphs)
>     // the list item gets ignored. We need it.
>-    if (isGroup()) {
>-        AccessibilityObject* parent = parentObject();
>-        if (parent && parent->isList())
>-            return IncludeObject;
>-    }
>+    if (isGroup() && parent->isList())
>+        return IncludeObject;
>+
>+    // Entries and password fields have extraneous children which we want to ignore.
>+    if (parent->isPasswordField() || parent->isTextControl())
>+        return IgnoreObject;
> 
>     return DefaultBehavior;
> }
>-- 
>1.6.3.3
>

Looks good to me otherwise, but r- because of the "not".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.