[Webkit-unassigned] [Bug 30681] Symbian port: JS Date operations very slow due to flaky POSIX date/time implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30681


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koivisto at iki.fi




--- Comment #10 from Antti Koivisto <koivisto at iki.fi>  2009-10-28 11:00:00 PDT ---
(In reply to comment #9)
> a) getUTCOffset() is only called from two functions in the same file:
> gregorianDateTimeToMS() and its inverse gregorianDateTimeToMS(). It is called
> from nowhere else for any port. In both places it is added to getDSTOffset(). I
> have changed both, so that their sum is consistent. 

At least a GregorianDateTime constructor in DateMath.h calls getUTCOffset() and
expects it not have DST included. Anyone could add mode code that relies on
getting the correct values from these functions.

If there truly is no valid reason to get UTC and DST offsets separately then
there probably should be only one function for returning the combined value.

> c) I am hesitent to add Qt dependecy to Javascript/WTF/* because this code is
> entirely Qt-unware. It also use C/C++ primitive types like double all over the
> place, so any work to introduce something like qreal and other Qt baggage would
> be quite intrusive and might make the code less readable for other ports. 
> 
> Thanks again for your time and help!

You could probably put all Qt calls to a single file that does not expose Qt to
the rest of the JSC. But you are right that avoiding the dependency is probably
good idea if it does not exist already.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.