[Webkit-unassigned] [Bug 30861] WebInspector: Adds InspectorTimelineAgent instrumentation for <script> tag processing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30861


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42031|                            |review-
               Flag|                            |




--- Comment #2 from Timothy Hatcher <timothy at hatcher.name>  2009-10-28 09:28:11 PDT ---
(From update of attachment 42031)

> +        timelineAgent->willScriptTag(sourceCode.url().isNull() ? String() : sourceCode.url().string(), sourceCode.startLine());
> +        timelineAgent->didScriptTag();
> +        ScriptTagTimelineRecordType = 10,

The wording is weird here. Would be better as
willEvaluateScriptTag/didEvaluateScriptTag/EvaluateScriptTagTimelineRecordType.

Otherwise r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.