[Webkit-unassigned] [Bug 15914] [GTK] Implement Unicode functionality using GLib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15914


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41866|review?                     |review-
               Flag|                            |




--- Comment #88 from Gustavo Noronha (kov) <gns at gnome.org>  2009-10-28 06:20:55 PDT ---
(From update of attachment 41866)
> +#elif USE(GLIB_UNICODE)
> +    GOwnPtr<char> utf8Source;
> +    utf8Source.set(g_utf16_to_utf8(characters, length, 0, 0, 0));
> +
> +    GOwnPtr<char> utf8Normalized;
> +    utf8Normalized.set(g_utf8_normalize(utf8Source.get(), -1, G_NORMALIZE_NFC));
> +
> +    long utf16Length;
> +    GOwnPtr<UChar> utf16Normalized;
> +    utf16Normalized.set(g_utf8_to_utf16(utf8Normalized.get(), -1, 0, &utf16Length, 0));
> +
> +    return newTextCodec(*this)->encode(utf16Normalized.get(), utf16Length, handling);


Regarding this, there's an exception to the camel case rule for acronyms, and
indeed all usages of "utf" in this file seem to be upper-cased, so I think we
should strive for consistency. This seems to be the only problem I am able to
spot by now. Sorry for being nit-picky, but please upload a patch with this
fixed so that we can use the commit queue =). Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.