[Webkit-unassigned] [Bug 22551] [GTK] API to start inspector for a WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22551





--- Comment #28 from Xan Lopez <xan.lopez at gmail.com>  2009-10-28 04:11:29 PDT ---
(In reply to comment #27)
> I don't have a too strong opinion on this. I am just following what's in
> GdkEvent, really. In Epiphany we have to cast back because the EphyEmbedEvent
> object stores this information as int. I am assuming that is a historical
> artifact from gecko times, and most API users would instead use GdkEvent
> directly.
> 
> http://library.gnome.org/devel/gdk/unstable/gdk-Events.html#gdk-event-get-coords
> 
> Xan, do you want to untie this? =)

Since doubles are used in GTK+ to store coordinates I prefer having the API
accept doubles. Better for us to cast it than having everyone do so.

Also,

+    g_return_if_fail((x >= 0) && (y >= 0));

Unneeded parenthesis.

+void webkit_web_inspector_execute_script(WebKitWebInspector* webInspector,
long callId, const gchar* script)
+{
+    g_return_if_fail(WEBKIT_IS_WEB_INSPECTOR(webInspector));

That could at least test script is not NULL, I guess?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.