[Webkit-unassigned] [Bug 30710] [Qt] QWebHistory::saveState() is inconsistent with the Qt API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30710





--- Comment #4 from Benjamin Poulain <benjamin.poulain at nokia.com>  2009-10-28 02:13:37 PDT ---
(In reply to comment #3)
> Few month ago there was a discussion in the Oslo office about these functions.
> The main argument for having saveState() and restoreState() was to keep
> coherence with other Qt classes (like QApplication, QMainWindow...). Second
> issue was a problem of multiple version of QWebHistory. The QDataSteream
> version was changed on most of Qt minor, but not in bug fix releases and the
> version format is X.Y (enum QDataStream::Version). As most of the QtWebkit bug
> fix are done by upstreaming the Webkit part, there is a chance that we will
> have to bump the version in a bug fix release. Qt's and Webkit's version number
> are out of sync.

To be able to work around a possible bug, maybe we should introduce a version
number in the stream?
This way we can deal with the bug silently by using this version number and we
will not ask the user to change an arbitrary version number for bugs of Webkit

> The QApplication is not a widget and it is hard to say that it is visible part
> of an application.

QApplication::saveState() is different. This function is used for session
management, it does not return a QByteArray.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.