[Webkit-unassigned] [Bug 29620] SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 27 12:04:49 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29620





--- Comment #11 from Eric Seidel <eric at webkit.org>  2009-10-27 12:04:47 PDT ---
http://trac.webkit.org/browser/trunk/WebCore/svg/SVGStyledElement.cpp#L243

is the code in question.  Note there is already a FIXME there:
    // FIXME: Is it possible that the style will not be shared at the time this
    // is called, but a later addition to the DOM will make it shared?
    if (!cssSVGAttr->style()->hasOneRef()) {
        cssSVGAttr->setDecl(0);
        int propId =
SVGStyledElement::cssPropertyIdForSVGAttributeName(cssSVGAttr->name());
        addCSSProperty(cssSVGAttr, propId, cssSVGAttr->value());
    }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list