[Webkit-unassigned] [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 27 10:40:50 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25534


Joanmarie Diggs <joanmarie.diggs at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41924|0                           |1
        is obsolete|                            |
  Attachment #41965|                            |review?
               Flag|                            |




--- Comment #17 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-10-27 10:40:50 PDT ---
Created an attachment (id=41965)
 --> (https://bugs.webkit.org/attachment.cgi?id=41965)
table 3 - corrected as per review

> I think it's better to do a if (!object)\nreturn 0; at the beginning here.

Done.

> Same comment about NULL than in the other patches (sorry about that!).

Done. No need to apologize. I need to re-read the style guide until it becomes
second nature.

Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list