[Webkit-unassigned] [Bug 30209] Cache::m_liveDecodedResource is not sorted by CachedResource::m_lastDecodedAccessTime

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 27 10:08:41 PDT 2009


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #41943|review?                     |review-
               Flag|                            |

--- Comment #13 from Darin Adler <darin at apple.com>  2009-10-27 10:08:40 PDT ---
(From update of attachment 41943)
Looks good.

> +        // that the tm_lastDecodedAccessTime is still zero or smaller than

That should be "m_" rather than "tm_".

> +        // by access time. The weakening of the invariant does not impose
> +        // a problem. For more details please see: https://bugs.webkit.org/show_bug.cgi?id=30209

That should be "does not pose a problem" rather than "does not impose a

As with the last round of review, since this patch is entirely about comments,
I'm holding the comments to a higher than usual standard. review- so you can
fix those two mistakes. Or you can fix them and land -- no need for a formal
review+ in my opinion.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list