[Webkit-unassigned] [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25534


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41924|review?                     |review-
               Flag|                            |




--- Comment #14 from Xan Lopez <xan.lopez at gmail.com>  2009-10-27 05:53:30 PDT ---
(From update of attachment 41924)
>+static const gchar* nameFromChildren(AccessibilityObject* object)
>+{
>+    if (object) {
>+        AccessibilityRenderObject::AccessibilityChildrenVector children = object->children();
>+        // Currently, object->stringValue() should be an empty String. This
>+        // might not be the case down the road.
>+        String name = object->stringValue();
>+        for (unsigned i = 0; i < children.size(); ++i)
>+            name += children.at(i).get()->stringValue();
>+        return returnString(name);
>+    }
>+
>+    return NULL;

I think it's better to do a if (!object)\nreturn 0; at the beginning here.

>+static AtkObject* webkit_accessible_table_get_column_header(AtkTable* table, gint column)
>+{
>+    // FIXME: This needs to be implemented.
>+    notImplemented();
>+    return NULL;
>+}

Same comment about NULL than in the other patches (sorry about that!).

r- for now, let's fix those two things.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.