[Webkit-unassigned] [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25534


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41898|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #11 from Xan Lopez <xan.lopez at gmail.com>  2009-10-27 05:12:45 PDT ---
(From update of attachment 41898)
>+static gint cellIndex(AccessibilityTableCell* AXCell, AccessibilityTable* AXTable)
>+{
>+    // Calculate the cell's index as if we had a traditional Gtk+ table in
>+    // which cells are all direct children of the table, arranged row-first.
>+    //

No need for that empty comment line.

>+    AccessibilityObject::AccessibilityChildrenVector allCells;
>+    AXTable->cells(allCells);
>+    AccessibilityObject::AccessibilityChildrenVector::iterator position;
>+    position = std::find(allCells.begin(), allCells.end(), AXCell);
>+    if (position == allCells.end())
>+        return -1;
>+    return position - allCells.begin();
>+}
>+
>+static AtkObject* webkit_accessible_table_ref_at(AtkTable* table, gint row, gint column)
>+{
>+    AccessibilityTableCell* AXCell = cell(table, row, column);
>+    if (!AXCell)
>+        return NULL;

In theory we try to use '0' instead of 'NULL' (per WebKit style guide), but I
realize this file is a mess wrt that.

>+    return AXCell->wrapper();
>+}
>+

I'll land this fixing those small details, thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.