[Webkit-unassigned] [Bug 25897] [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25897





--- Comment #4 from Jan Alonzo <jmalonzo at gmail.com>  2009-10-27 03:53:18 PDT ---
(From update of attachment 41882)
I just have some nits.

> +    // gives platforms the opportunity to indicate if and how an object should
> +    // be included

No need to wrap.

>  #if HAVE(ACCESSIBILITY)
> -    bool accessibilityPlatformIncludesObject() const;
> +    AccessibilityObjectPlatformInclusion accessibilityPlatformIncludesObject() const;
>  #else
> -    bool accessibilityPlatformIncludesObject() const { return false; }
> +    // this won't ever get called....
> +    AccessibilityObjectPlatformInclusion accessibilityPlatformIncludesObject() const { return DefaultBehavior; }

It can be called if people don't want AX enabled. Aside from that patch looks
OK.

> Also, Xan reminded me of the one-thing-per-patch rule. Sorry! :-) So this patch

One-thing-per-bug rule would've been nice as well. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.