[Webkit-unassigned] [Bug 30098] commit-queue can wrongly reject patches if the buildbots are behind

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30098





--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-10-27 01:39:06 PDT ---
Actually checking to make sure that there are no pending builds isn't quite
strong enough.  If I want to actually make sure that the very latest build was
green then I need to make sure that every builder is "idle".

Adam Barth points out that I should have a fall-back mode, where if the
builders are busy I do an extra build/test step w/o the patch applied first, if
that passes then I go ahead and commit.  That might just be extra complexity
for an incomplete solution, but then again it might be a big help.

As-is waiting for the builders to all be idle before letting the commit-queue
run is going to greatly slow down the rate at which the commit-queue can land
patches as it will be always tied to run as slowly as the slowest bot that it's
watching. :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.