[Webkit-unassigned] [Bug 30555] Provide a way to get counter values with layoutTestContoller

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30555





--- Comment #22 from Shinichiro Hamaji <hamaji at chromium.org>  2009-10-26 22:11:22 PDT ---
> Now that we have a countervalueForElementById function you could make the test
> work without a setTimeout.
> 
> The first set of calls to counterValueForElementById will force a layout and
> compute the counter values. So then you will have a valid test of a subsequent
> dynamic change. The test will write out the values both before and after the
> dynamic change.

I see. Fixed.

> We use "0", not "NULL", for this in WebKit code.

Fixed.

> I am not sure that you included changes to make bots stay green on non-Mac
> platforms, either by skipping the tests or landing expected results that expect
> the test to fail. If you did, I could say review+ and we could land this first
> version.
> 
> For now, review- because of the two comments above and my uncertainty about
> what you are doing for the other platforms at this time.

I was planning to commit my change after my patches for other platforms become
ready. So, I think we don't need to push expected failures, right? Now I've
just uploaded the patches for gtk and qt port. I'll work on windows tomorrow
(I'm downloading service pack for Visual Studio now :). Also, I want to add the
same method for chromium's test shell before I commit this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.