[Webkit-unassigned] [Bug 30786] Fix QtWebKit build for WIN_OS if Netscape plug-in support is turned off and refactor some related code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30786





--- Comment #2 from Antti Koivisto <koivisto at iki.fi>  2009-10-26 16:39:41 PDT ---
(From update of attachment 41889)
Why not keep the windows specific function in the PluginPackageWin? Having both
PluginPackageWin and Windows ifdefs in base PluginPackage.cpp seems weird.

> +#if PLATFORM(WIN_OS)
> +    if (m_moduleVersion.mostSig != compareVersion.mostSig)
> +        return m_moduleVersion.mostSig > compareVersion.mostSig ? 1 : -1;
> +    if (m_moduleVersion.leastSig != compareVersion.leastSig)
> +        return m_moduleVersion.leastSig > compareVersion.leastSig ? 1 : -1;

I realize this is copy code but is this really correct? If mostSig differs the
leastSig is ignored? (i don't really know anything about windows plugins).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.