[Webkit-unassigned] [Bug 30786] New: Fix QtWebKit build for WIN_OS if Netscape plug-in support is turned off and refactor some related code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30786

           Summary: Fix QtWebKit build for WIN_OS if Netscape plug-in
                    support is turned off and refactor some related code
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: laszlo.1.gombos at nokia.com


QtWebKit for WIN_OS fails to link if Netscape plug-in support is turned off as
there is no implementation for PluginPackage::compareFileVersion function.
There is one implementation for this function in PluginPackage.cpp and that is
guarded with the ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH which is not enabled for
WIN_OS (see Platform.h). There is also an implementation for this interface in
PluginPackageWin.cpp which is not built when Netscape plug-in support is turned
off.

This problem domain is related to the PlatformModuleVersion type definition
(see FileSystem.h). Notice that the there are a few areas where type definition
is repeated (copied) instead of reused (e.g. PlatformModuleVersion type
definition is repeated for 2x) - One should attempt to refactor FileSystem.h as
part of the build fix patch as I think these changes belong together.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.