[Webkit-unassigned] [Bug 30572] Unification of using null device in perl scripts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30572





--- Comment #5 from Csaba Osztrogonac <ossy at webkit.org>  2009-10-26 10:40:32 PDT ---
(In reply to comment #2)
> (From update of attachment 41507 [details])
> I believe our style is to put spaces around '.' operators.
Updated.

> Also, I'm surprised that sometimes you use local variables to hold $devNull and
> sometimes you make direct calls to File::Spec->devnull().
I modified bisect-builds, we can use exec instead of backstick operator.

But I have no idea what should we do with backstick of svn-create-patch:
    print `svn cat ${sourceFile} | diff -u $devNull - | tail -n +3`;

We can't use system or exec insted of backsticks. 
I think we shouldn't rewrite this code at any price.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.