[Webkit-unassigned] [Bug 30765] Nightly build of Safari and Chrome 4 remove two functions registered to window.onload event when calling removeEventListener to remove the first one of them.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30765


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41864|review?                     |review-
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2009-10-26 07:42:37 PDT ---
(From update of attachment 41864)
Thanks for taking this on!

There is no need to add this extra looping to solve the problem.

A better way to fix this is follow the style already used in the code. We just
need to change FiringEventEndIterator to have pointers to both "i" and "end"
and have it decrease "i" as well as "end" if the listener being removed is
before the index.

There are also some minor style problems with this code: Some of the code is
indented two spaces and "old_end" is the wrong style for WebKit.

And the patch needs to include a regression test for the tests directory as
well as a bug fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.