[Webkit-unassigned] [Bug 30467] Add DOMTimer support to InspectorTimelineAgent.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 25 22:45:42 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=30467
--- Comment #7 from Timothy Hatcher <timothy at hatcher.name> 2009-10-25 22:45:42 PDT ---
(From update of attachment 41840)
> +#if ENABLE(INSPECTOR)
> + static InspectorTimelineAgent* inspectorTimelineAgent(ScriptExecutionContext*);
> +#endif
> +
> int m_timeoutId;
> int m_nestingLevel;
> OwnPtr<ScheduledAction> m_action;
> @@ -72,6 +79,15 @@ namespace WebCore {
> static double s_minTimerInterval;
> };
>
> +#if ENABLE(INSPECTOR)
> +inline InspectorTimelineAgent* DOMTimer::inspectorTimelineAgent(ScriptExecutionContext* context)
> +{
> + if (context->isDocument())
> + return static_cast<Document*>(context)->inspectorTimelineAgent();
> + return 0;
> +}
> +#endif
> +
I didn't realize this was static before. It would be good to have this as a
static in InspectorTimelineAgent.h then.
Maybe as:
InspectorTimelineAgent::inspectorTimelineAgent(ScriptExecutionContext* context)
Who else might need that same code?
Otherwise looks good to me.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list