[Webkit-unassigned] [Bug 30467] Add DOMTimer support to InspectorTimelineAgent.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 25 20:33:11 PDT 2009


--- Comment #4 from Timothy Hatcher <timothy at hatcher.name>  2009-10-25 20:33:11 PDT ---
(From update of attachment 41839)
I like the term "Record" over "TimelineItem". But I see the logic in the name

> +    if (context->isDocument())
> +        if (InspectorTimelineAgent* timelineAgent = static_cast<Document*>(context)->inspectorTimelineAgent())
> +            timelineAgent->didInstallTimer(timer->m_timeoutId, timeout, singleShot);

There should be braces around the outer if() since it is multi-line inside.

This would be better as helper inline function that returns
InspectorTimelineAgent* to share with the other spots in this code.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list