[Webkit-unassigned] [Bug 30462] MediaPlayer doesn't set properties on new privates
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 25 17:36:17 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=30462
Gustavo Noronha (kov) <gns at gnome.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #41825|review? |review-
Flag| |
--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org> 2009-10-25 17:36:17 PDT ---
(From update of attachment 41825)
> LOG_VERBOSE(Media, "Seek: %" GST_TIME_FORMAT, GST_TIME_ARGS(sec));
> - if (!gst_element_seek( m_playBin, m_rate,
> + if (!gst_element_seek( m_playBin, m_player->rate(),
^
You could take the oportunity to fix this weird space here =).
> - g_object_set(G_OBJECT(m_playBin), "mute", mute, NULL);
> + g_object_set(G_OBJECT(m_playBin), "volume", (double) volume, NULL);
You should use static_cast<double>() here, mind the space.
> @@ -673,12 +657,11 @@ void MediaPlayerPrivate::paint(GraphicsContext* context, const IntRect& rect)
>
> // paint the rectangle on the context and draw the surface inside.
> cairo_translate(cr, rect.x() + gapWidth, rect.y() + gapHeight);
> - cairo_rectangle(cr, 0, 0, rect.width(), rect.height());
> cairo_scale(cr, doublePixelAspectRatioNumerator / doublePixelAspectRatioDenominator,
> doublePixelAspectRatioDenominator / doublePixelAspectRatioNumerator);
> cairo_scale(cr, scale, scale);
> cairo_set_source_surface(cr, src, 0, 0);
> - cairo_fill(cr);
> + cairo_paint(cr);
> cairo_restore(cr);
These changes look unrelated, can they go in a separate patch?
> - void setMuted(bool);
Just so it's crystal clear: this is being removed because the mute logic is
already handled by HTMLMediaElement? I'll say r- mainly because of the
unrelated changes above, but otherwise looks fine to me, so should be good to
land after fixing the nits.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list