[Webkit-unassigned] [Bug 30750] Build improvements for Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30750


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41797|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2009-10-25 17:25:52 PDT ---
(From update of attachment 41797)
If the comments in the change log explained why these are good changes, this
patch would be much better! It could simply say something like "Use winresrc.h
because it exists even when MFC is not installed, and is all that's needed
here." And the equivalent elsewhere.

Or the bug title could be more specific: "Make .rc files compile on Windows
without depending on MFC headers." Then you might be OK without further
comments.

Either of these changes would remove the mysterious "improvements" aspect of
this and make this small simple patch much better!

r=me, as is. Next time, please be clearer in the change log or the bug title or
both.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.