[Webkit-unassigned] [Bug 30709] Web Inspector: Pretty Print all HTML Collection Types like we do for NodeList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30709


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |joepeck at webkit.org
                   |kit.org                     |




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org>  2009-10-25 10:34:31 PDT ---
Created an attachment (id=41821)
 --> (https://bugs.webkit.org/attachment.cgi?id=41821)
[PATCH] Example Patch

I don't feel this should be a final patch due to the following two points:

- HTMLAllCollection as per HTML5 this morning should extend HTMLCollection:

  Make collections inherit from HTMLCollection:
  Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=8035

  Commit Diff:
  http://html5.org/tools/web-apps-tracker?from=4322&to=4323

> -  <pre class="idl">interface <dfn>HTMLAllCollection</dfn> {
> +  <pre class="idl">interface <dfn>HTMLAllCollection</dfn> : <span>HTMLCollection</span> {

If this patch is desired now, how should I indicate in the test that the
expected results should be updated once HTMLAllCollection is true for
instanceof HTMLCollection.  Will just a comment suffice?

- Likewise I wanted to future proof formatting on some other collections like
HTMLPropertyCollection, PropertyNodeList, DOMTokenList, DOMSettableTokenList,
and DOMStringMap which are currently unimplemented in WebKit. Should I add
checks for these with comments for when they fail that we should implement a
pretty-printer, or is that bad style?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.