[Webkit-unassigned] [Bug 29506] PrettyPatch should show images even when they have the wrong mime type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 25 08:32:29 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=29506


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41760|review?                     |review+
               Flag|                            |




--- Comment #2 from Adam Roben (aroben) <aroben at apple.com>  2009-10-25 08:32:29 PDT ---
(From update of attachment 41760)
It seems a little strange for has_image_suffix to be an instance method of the
FileDiff class. It would probably be better as a method of String or just in
the private section of the PrettyPatch module.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list