[Webkit-unassigned] [Bug 30324] Console shows no repeat count when repeatedly logging an Event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30324


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41789|review?                     |review-
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2009-10-24 17:48:07 PDT ---
(From update of attachment 41789)
Looks good. Couple of nits, otherwise r+.

> +            msgCopy = new WebInspector.ConsoleMessage(msg.source, msg.type, msg.level, msg.line, msg.url, msg.groupLevel, count - prevRepeatCount);

You should either use this.repeatCountBeforeCommand here or remove it since it
is no more used.

> +    incrementErrorWarningCount: function(msg) {

Please use _incrementErrorWarningCount as this is private method.


> +    updateRepeatCount: function() {

Also private


> -    toMessageElement: function()
> +    get element()

(No need to fix): Why rename? Since this code below is kinda ugly:

> +        this._element = WebInspector.ConsoleMessage.prototype.__lookupGetter__("element").call(this);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.