[Webkit-unassigned] [Bug 30707] WebInspector: Refactors InspectorTimelineAgent to eliminate TimelineItem classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30707


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41761|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #6 from Pavel Feldman <pfeldman at chromium.org>  2009-10-23 16:19:45 PDT ---
(From update of attachment 41761)
Couple of  nits that can be addressed in further patches.

+     TimelineItemEntry entry = m_itemStack.last();

ASSERT(m_itemStack.size()); ?

+     if (m_itemStack.isEmpty()) {


no { here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.