[Webkit-unassigned] [Bug 30683] svn-apply's fixChangeLogPatch function seems broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30683





--- Comment #11 from Eric Seidel <eric at webkit.org>  2009-10-23 15:48:29 PDT ---
(In reply to comment #10)
> (In reply to comment #6)
> > Eh, my comment above was unfair.  I can understand the desire to have these
> > scripts be stand-alone, but I don't think that it's worth the cost of having
> > copy/paste code like this.  At least not functions as huge and complicated as
> > this one.
> 
> At the time I wrote this code, I was told that it was more important for the
> scripts to be standalone than to share code.

Hum... It would that now that other code is being shared using VCSUtils.pm we
should re-visit that decision.  If we decide to start sharing more code there
is definitely a bunch more we can share yet.  I am very interested in your
input on such a decision.  Obviously my bias above has already been stated. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.