[Webkit-unassigned] [Bug 29651] [HTML5] Add a way for an application to register as a protocol handler.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29651





--- Comment #12 from B. Green <brg at chromium.org>  2009-10-23 15:41:15 PDT ---

The following are responses to the previous review and other offline comments,

#1. Please include the specification for the APIs in the ChangeLog.

Done, links to the HTML5 spec for both APIs have been added to the ChangeLog.

#2. Please include the reasoning why the behavior of these APIs is not
implemented in webkit beyond passing parameters to the UA.

Done, this has been added to the ChangeLog.

#3.  runJavascriptXXX is used for displaying a modal dialog to the user, please
rename.

Done, the APIs in Chrome and ChromeClient have been changed to registerXXX from
runJavascriptRegsterXXX.

#4.  By unescaping the URL in the registerProtocolHandler call passed to
ChromClient you may be losing information.

I have removed the call to unescape the URL.  The display text and ascii
protocol/content name are still unescaped.

#5.  Explain why you have platform specific tests.

Done.  This is completed in in the LayoutTests change log.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.