[Webkit-unassigned] [Bug 30623] [GTK] Enable DOM clipboard and drag-and-drop access

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 23 14:43:42 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30623





--- Comment #2 from Martin Robinson <martin.james.robinson at gmail.com>  2009-10-23 14:43:43 PDT ---
Xan asked me to write a high-level description of this patch to make it a
little easier to review:

The DOM DataTransfer object (for the GTK port this is
WebCore/platform/gtk/ClipboardGtk.cpp) needs to be able to read and modify both
clipboard contents and drag and drop data. Unlike OS X where both of these
operations are exposed via an NSPasteboard, GTK+/GLib uses two different slices
of API for drag-and-drop and clipboard access.

This patch introduces platform/gtk/DataObjectGtk.cpp, comparable to
platform/chromium/ChromiumDataObject.cpp, which is a layer of indirection
between ClipboardGtk and the actual GTK+/GLib APIs. When clipboard reads
happen, all data is read from the clipboard and stored in the DataObject.
Eventually drag data can be read into the same DataObject.

This first patch does yet not touch ClipboardGtk, but replaces the old logic
for reading and writing clipboard data to use DataObjectGtk. This old logic was
in two places:
1. PasteboardGtk -- used for all non-DataTransfer clipboard access.
2. EditorClientGtk -- code to handle GDK_SELECTION_PRIMARY clipboard access
(activated when some text is selected).

Information about what drag/clipboard data targets has also been moved from
WebKit/gtk/webkit/webkitwebview.cpp to
WebKit/gtk/WebCoreSupport/PasteboardHelperGtk.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list