[Webkit-unassigned] [Bug 30365] empty optgroup crashes browser upon form submit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 22 19:57:40 PDT 2009


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #41693|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2009-10-22 19:57:40 PDT ---
(From update of attachment 41693)
+    https://bugs.webkit.org/show_bug.cgi?id=30365

Tab here, please use spaces.

The comment above the code that you modified is misguiding - as we now know,
this case can legitimately happen if the select only contains optgroup
children. And the comment doesn't suggest any criteria to verify if it's still
relevant - maybe we have already fixed that? The comment should mention the
case with optgroups, and then say that this should be the only such case. Maybe
you could add an assertion to this effect and run layout tests to check if the
assertion is hit.

r=me as is, with only the tab fixed, but this code could benefit from a little
more attention.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list