[Webkit-unassigned] [Bug 20780] when choosing an auto-completed value in a text input field the javascript 'change' event is not fired.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 22 14:42:08 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=20780
--- Comment #8 from Daniel Bates <dbates at webkit.org> 2009-10-22 14:42:08 PDT ---
Remarks:
Whenever you press a key on the keyboard:
RenderTextControl::subtreeHasChanged is called, which sets m_edited,
m_userEdited = true.
When autocompletion kicks in the call flow is:
DOMHTML::_replaceCharactersInRange->HTMLInputElement::setValue->RenderTextControlSingleLine::updateFromElement->RenderTextControl::setInnerTextValue
Note, RenderTextControl::setInnerTextValue always sets m_edited, m_userEdited =
false.
Since a user must type at least one character before the field is autocompleted
(if applicable), RenderTextControl::setInnerTextValue should not explicitly set
m_edited = false. Instead, RenderTextControl::setInnerTextValue should not
touch this field.
On another note, the field RenderTextControl::m_userEdited seems to imply
whether the field was edited by the user. Since the auto-completed result is
not typed by the user, I believe m_userEdited should be set to false in
RenderTextControl::setInnerTextValue (as it is currently).
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list