[Webkit-unassigned] [Bug 30177] Volume slider always starts at half volume
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 22 06:24:22 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=30177
Eric Carlson <eric.carlson at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #41621|review? |review-
Flag| |
--- Comment #13 from Eric Carlson <eric.carlson at apple.com> 2009-10-22 06:24:21 PDT ---
(From update of attachment 41621)
> LayoutTests/media/video-volume-slider.html
Committing this patch as-is will break the build because the controller UI on
SnowLeopard is different from that on all other ports. I really appreciate that
you went to the extra effort to create this test with results for other ports,
but I don't think it helps to have the test run just yet because it will be a
PIYA to get the correct results and none of the other ports implements the
slider yet. I don't want to lose the test because we will add a volume slider,
so I would like to see it committed but added to the skip lists.
> +void MediaControlVolumeSliderElement::update()
> +{
> + setValue(String::number(m_mediaElement->volume()));
> + MediaControlInputElement::update();
> +}
setValue always causes a renderer update, so it would be more efficient to only
call it when the value is out of sync with the element's volume.
r- for now
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list