[Webkit-unassigned] [Bug 30670] [Qt] symbian buildfix for resourceloadnotifier

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30670


Holger Freyther <zecke at selfish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41654|review?                     |review-
               Flag|                            |




--- Comment #3 from Holger Freyther <zecke at selfish.org>  2009-10-22 05:02:11 PDT ---
(From update of attachment 41654)

>  #include <wtf/Noncopyable.h>
> -

^^^ we don't add whitespace like this...


>  namespace WebCore {
>  
>  class AuthenticationChallenge;
> @@ -40,7 +39,7 @@ class Frame;
>  class ResourceError;
>  class ResourceLoader;
>  class ResourceResponse;
> -class ResourceRequest;
> +struct ResourceRequest;
>  class ScriptString;


Yes and No. CF, Chromium, CURL, SOUP refer to it as struct ResourceRequest, mac
is having a proper class.

WebCore/platform/network/mac/ResourceRequest.h:41:    class ResourceRequest :
public ResourceRequestBase {

I think it is time to change the other ports to class ResourceRequest as well
because the base class is declared as a "class".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.