[Webkit-unassigned] [Bug 29803] [Qt] QWebHistory and QWebPage autotests crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29803


Holger Freyther <zecke at selfish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41649|review?                     |review-
               Flag|                            |




--- Comment #20 from Holger Freyther <zecke at selfish.org>  2009-10-22 04:51:58 PDT ---
(From update of attachment 41649)

>      frameLoaderClient->setFrame(qframe, frame);
> -
>      frame->init();
> +    // Delay the signal QWebPage::frameCreated(QWebFrame*), because the QwebPage might be not
> +    // fully created (no way to connect to the signal).

Whitespace, spelling... QwebPage vs. QWebPage..



> +        Emission of the frameCreated signal was moved to the QWebFrame::init()
> +        and delayed.

I didn't read most of the bug report. The ChangeLog should answer the question
why? The QWebPage pretty much knows when the mainFrame got created? Why do we
need to delay this signal?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.