[Webkit-unassigned] [Bug 30645] REGRESSION: 2 failures in run-webkit-unittests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30645





--- Comment #6 from Carol Szabo <carol.szabo at nokia.com>  2009-10-21 20:46:39 PDT ---
(In reply to comment #3)
> (From update of attachment 41614 [details])
> >          self.assert_multi_line_lint(
> >              'namespace WebCore {\n'
> >              '#if 0\n'
> > -            'class Document {\n'
> > +            '    class Document {\n'
> >              '};\n'
> 
> Really? Indent the line starting the class definition but not the line ending
> it?

I take my previous comment back. The correct style as I read the style document
is not to indent the class definition. This is bad style and the checker should
complain.
I agree that this patch is hard to review because it does not give enough
context. The next line in the file says that the checker should complain about
the indented class definition.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.