[Webkit-unassigned] [Bug 30504] wxPython bindings missing 'WebViewDOMElementInfo'.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 18:55:33 PDT 2009


--- Comment #9 from Kevin Ollivier <kevino at theolliviers.com>  2009-10-21 18:55:33 PDT ---
(In reply to comment #8)
> Kinda lame to land with my disagreement.

Sorry, I've been busy prepping a release and so I forgot to write back to you
myself, but Pedro did reply with an answer to you already (which I agree with).

Moreover, I did not see any reason to continue discussing this particular issue
because, well, I do frankly know more about the wx port than you do having
actually written the file being reviewed, and even I have no idea what
relevance questions about unit tests have to this particular change. The only
way I could possibly see to unit test this particular change is to actively
test that every SWIG generated Python class does indeed expose every method we
intend to make available to users, and that clearly sounds like overkill to me.
Even if the issue were considered relevant, the concern should have been raised
when the Python bindings were first submitted (or now in a separate ticket
named "wxPython bindings should test that their methods exist"), and not as
part of this particular patch review. In other words, no matter how I look at
it, I can't see how the unit testing question is appropriate for this
particular patch review.

I appreciate that sometimes r? patches stagnate for a couple weeks or more, and
at that time they do deserve some sort of response even if not from someone
explicitly knowledgeable in that area, but I rarely let a wx port r? patch sit
in the tree for weeks; in fact, I bet most are handled within 24 hours, so I
don't really understand the urge to get wx patches reviewed and out of the
queue when they are going to be taken care of promptly anyway by someone more
knowledgeable in that area.

I think the wx(Python) port maintainer is probably the best person to take the
first crack at a completely wx(Python)-specific patch, don't you? It seems
almost a waste of time and effort not to, actually.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list