[Webkit-unassigned] [Bug 30437] Japanese Text Search Problem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 15:22:03 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30437


Jungshik Shin <jshin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jshin at chromium.org




--- Comment #27 from Jungshik Shin <jshin at chromium.org>  2009-10-21 15:22:02 PDT ---
Sorry I'm late here, but this patch breaks non-Japanese search (e.g. Swedish).
Before the change, the search collator was locale-dependent. That is, if you
use Japanese Safari, you'd get the collator tailored for Japanese (which I
think does the right thing for Japanese). The same is true of other languages.

The intent of the patch is to make Japanese search work *regardless of the
current locale (UI language)*, which I support. However, it should be done
without breaking search in Swedish, German, Finnish or any other language.

The patch here breaks that because it throws away the locale-dependent collator
right after creating one and replace it with the UCA + Japanese tailoring. 

The way to do that is to get the collation rule string for the current locale
and combine it with the Japanese tailoring (added in the patch) and build a new
collator from the combined rule strings. (I just went over the patch with one
of ICU's leading contributors). 

I'll make a patch to do the above in a couple of days.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list