[Webkit-unassigned] [Bug 18027] CSS3 Selector Test: combination of hover and multiple chained sibling selector fails in Webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 12:44:50 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=18027


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38476|review?                     |review-
               Flag|                            |




--- Comment #12 from Eric Seidel <eric at webkit.org>  2009-10-21 12:44:49 PDT ---
(From update of attachment 38476)
No objections or commentary in the 3 months that this patch has been up for
review.

As far as I can tell, this looks fine to me.

Yusuke, this will cause failure on other platforms since you're only adding Mac
results.

We have 3 options:
1.  Move the results next to the tests instead of in platform/mac.
2.  Add results for other platforms (only necessary if they differ, otherwise
#1 is better).
3.  Make these tests dumpAsText (possible by using getComputedStyle).

If the tests were OK, I would r+ this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list