[Webkit-unassigned] [Bug 30621] Printing using other media types then "print"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 06:23:27 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30621


Holger Freyther <zecke at selfish.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41556|review?                     |review-
               Flag|                            |




--- Comment #2 from Holger Freyther <zecke at selfish.org>  2009-10-21 06:23:27 PDT ---
(From update of attachment 41556)

>  void Frame::setPrinting(bool printing, float minPageWidth, float maxPageWidth, bool adjustViewSize)
>  {
> +    String mediaType;
> +    if (m_page->settings())


Use:

     String mediaType = settings() ? settings()->printingMediaType() : "print";

reasoning:
     - m_page can be NULL... m_page->settings() not..
     - provide a default for printingMediaType as well..



> +*/
> +QString QWebSettings::printingMediaType() const
> +{
> +    return d->printingMediaType;
> +}

Which can be QString() which is not what your API doc said... have a default...
and let it be "print"

but in general this is a nice patch!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list