[Webkit-unassigned] [Bug 30555] Add layoutTestContoller.dumpCounterValues

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30555





--- Comment #7 from Shinichiro Hamaji <hamaji at chromium.org>  2009-10-21 03:28:44 PDT ---
Thanks for the review!

> Using printf() here is inelegant and limits the usefulness of the code. I think
> a function that returns a string would be better and more flexible. You could
> decide to dump the value in DumpRenderTree, but you could also just expose it
> to the test through the LayoutTestController.

I see. I update my patch and it returns String. 

> It’s somewhat confusing that a function called dumpCounterNode() doesn’t take a
> counter as its argument. Is the argument even necessary?

The argument is the root node of render tree and dumpCounterNode (this name was
gone in my new patch) outputted all counters in the render tree. I think the
name of this function was wrong. Now I changed the name to
counterValuesFromRenderTree. I hope this name sounds better.

Also, as now we don't output counter tree, I renamed the dump function from
dumpCounterNode to dumpCounterValues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.