[Webkit-unassigned] [Bug 30555] Add layoutTestContoller.dumpCounterNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30555





--- Comment #5 from mitz at webkit.org  2009-10-21 02:41:27 PDT ---
(From update of attachment 41553)
> +void dumpCounterNode(RenderObject* o)
> +{
> +    for (; o; o = o->nextInPreOrder()) {
> +        if (o->isCounter()) {
> +            String str(toRenderText(o)->originalText().releaseRef());
> +            printf("%s\n", str.utf8().data());
> +        }
> +    }
> +}

Using printf() here is inelegant and limits the usefulness of the code. I think
a function that returns a string would be better and more flexible. You could
decide to dump the value in DumpRenderTree, but you could also just expose it
to the test through the LayoutTestController.

It’s somewhat confusing that a function called dumpCounterNode() doesn’t take a
counter as its argument. Is the argument even necessary?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.