[Webkit-unassigned] [Bug 30437] Japanese Text Search Problem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30437





--- Comment #25 from Satoshi Nakagawa <psychs at limechat.net>  2009-10-21 00:49:03 PDT ---
(In reply to comment #22)
> (From update of attachment 41543 [details])
> > +    UCollator* collator = ucol_openRules(japaneseKanaCollationRules, -1, UCOL_DEFAULT, UCOL_DEFAULT_STRENGTH, 0, &status);
> > +    ASSERT(status == U_ZERO_ERROR || status == U_USING_FALLBACK_WARNING || status == U_USING_DEFAULT_WARNING);
> 
> Are all three of these expected here for some reason, or are you just ignoring
> the same set I ignored for usearch_open?

It's just for ignoring the same set as for usearch_open.
I read ICU documents, and I thought it's better to ignore them.

http://icu-project.org/apiref/icu4c/ucol_8h.html#a128ea0ed3869415c1c96a9a2c997c2d
http://icu-project.org/apiref/icu4c/utypes_8h.html#3343c1c8a8377277046774691c98d78c

Probably,  using U_SUCCESS() would be better for assertion.

> > +    usearch_setCollator(searcher, collator(), &status);
> > +    ASSERT(status == U_ZERO_ERROR || status == U_USING_FALLBACK_WARNING || status == U_USING_DEFAULT_WARNING);
> 
> Same question.
> 
> r=me, but I would like to hear the answer to that question at some point.

The same here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.