[Webkit-unassigned] [Bug 19879] Inspector should support monitorEvents/un monitorEvents() in the command line

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 15:39:18 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=19879


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41089|review?                     |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2009-10-20 15:39:18 PDT ---
(From update of attachment 41089)
> +                if (t[i] == \"mouse\") \

Use ===


> +                    te = te.concat([\"mousedown\", \"mouseup\", \"click\", \"dblclick\", \

Use splice instead in order not to create new array instances.

> +                if (t[i] == \"key\") \

Use ===


> +                o.removeEventListener

Should you test for addEventListener / removeEvent listener on an object?
Does monitorEvent(null) provide meaningful feedback well?

Other than that r+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list